TorLogger: prevent double initialization #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aarani haha this breaks tests; can you finish the PR please? |
|
@aarani why is CI still red? |
aarani
force-pushed
the
knocte-patch-1
branch
2 times, most recently
from
22b9ed5
to
2e9fcf9
Compare
knocte
commented
Aug 2, 2023
|
@aarani the rename commit has disappeared 😭 |
No clue what is happening the branch has that commit but PR doesn't |
I repushed 1 by 1 it seems to be back |
aarani
force-pushed
the
knocte-patch-1
branch
3 times, most recently
from
5e94a1b
to
5c78eed
Compare
Purpose of our HS browsing tests is to make sure we can connect to the server and just receieving a status code means we are connected so there's no need to make sure the status code is 200, this is especially true because TorHttpClient doesn't handle redirects which causes Unsuccessful- HttpRequestException when there's a redirect.
Co-authored-by: Afshin Arani <afshin@arani.dev>
This commit renames UnsuccessfulHttpRequest exception to UnsuccessfulHttpResponseException.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.